Fix sandbox runtime container image inconsistency #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes All-Hands-AI#4749 Update `SANDBOX_RUNTIME_CONTAINER_IMAGE` value to be consistent across the repository. * **compose.yml** - Update `SANDBOX_RUNTIME_CONTAINER_IMAGE` to `runtime:0.12-nikolaik`. * **containers/dev/compose.yml** - Update `SANDBOX_RUNTIME_CONTAINER_IMAGE` to `runtime:0.12-nikolaik`. * **docs/modules/usage/installation.mdx** - Add a note emphasizing the importance of synchronizing the sandbox runtime and backend versions. * **README.md** - Add a note emphasizing the importance of synchronizing the sandbox runtime and backend versions.
mamoodi
reviewed
Nov 5, 2024
| @@ -127,3 +127,7 @@ For a list of open source projects and licenses used in OpenHands, please see ou | |||
| url={https://arxiv.org/abs/2407.16741}, | |||
| } | |||
| ``` | |||
|
|
|||
| ## Note | |||
There was a problem hiding this comment.
Not necessary. Can you please remove this?
mamoodi
reviewed
Nov 5, 2024
|
|
||
| ## Note | ||
|
|
||
| It is important to keep the sandbox runtime and backend versions in sync to avoid errors. |
There was a problem hiding this comment.
Not necessary. Can you please remove this?
mamoodi
reviewed
Nov 5, 2024
| @@ -11,7 +11,7 @@ services: | |||
| - BACKEND_HOST=${BACKEND_HOST:-"0.0.0.0"} | |||
| - SANDBOX_API_HOSTNAME=host.docker.internal | |||
| # | |||
| - SANDBOX_RUNTIME_CONTAINER_IMAGE=${SANDBOX_RUNTIME_CONTAINER_IMAGE:-ghcr.io/all-hands-ai/runtime:0.9-nikolaik} | |||
| - SANDBOX_RUNTIME_CONTAINER_IMAGE=${SANDBOX_RUNTIME_CONTAINER_IMAGE:-ghcr.io/all-hands-ai/runtime:0.12-nikolaik} | |||
There was a problem hiding this comment.
Thanks for these changes! I don't think this is used so it was forgotten. We will keep them in mind going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4749
Update
SANDBOX_RUNTIME_CONTAINER_IMAGEvalue to be consistent across the repository.compose.yml
SANDBOX_RUNTIME_CONTAINER_IMAGEtoruntime:0.12-nikolaik.containers/dev/compose.yml
SANDBOX_RUNTIME_CONTAINER_IMAGEtoruntime:0.12-nikolaik.docs/modules/usage/installation.mdx
README.md