Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary issue for kernels #329

Open
alexpiet opened this issue Oct 11, 2021 · 1 comment
Open

Boundary issue for kernels #329

alexpiet opened this issue Oct 11, 2021 · 1 comment

Comments

@alexpiet
Copy link
Collaborator

Right now, aligning events for the kernels are binned into fit_trace_bins, and then I construct the toeplitz matrix. However, this creates a boundary issue whereby events that happen outside the bins, but within a kernel length away from the bins are not influencing the design matrix, but they should be.

In order to fix this, I think I need to create a wider set of bins, and then trim the toeplitz matrix. This will only impact a small part of the design matrix, so its low priority.

@alexpiet
Copy link
Collaborator Author

toeplitz

The running and pupil kernels show the issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant