Open
Conversation
This reverts commit 663ecae.
| 9.0.0b4 | ||
| +++++++ | ||
| * Add `--driver-type` to the `az aks nodepool add` command. | ||
|
|
There was a problem hiding this comment.
🔎
Please ensure to format the placeholder and URLs properly as per the guidelines:
+To release a new version, please select a new version number (usually plus 1 to last patch version, X.Y.Z -> Major.Minor.Patch, more details in `\doc <https://semver.org/>`_), and then add a new section named as the new version number in this file, the content should include the new modifications and everything from the *Pending* section. Finally, update the `VERSION` variable in `setup.py` with this new version number.- Replace
\doc <https://semver.org/>_ with appropriate surrounding HTML tags or use backticks for placeholders and ensure the URL link is marked as an example if not accessible.
|
|
||
| # GPU Driver Type Consts | ||
| CONST_GPU_DRIVER_TYPE_CUDA = "CUDA" | ||
| CONST_GPU_DRIVER_TYPE_GRID = "GRID" |
There was a problem hiding this comment.
🔎
Consider using an enumeration to define the constants for better code organization and type safety.
from enum import Enum
class TlsManagement(Enum):
MANAGED = "Managed"
NONE = "None"
class GpuDriverType(Enum):
CUDA = "CUDA"
GRID = "GRID"| short-summary: To skip GPU driver auto installation by AKS on a nodepool using GPU vm size if customers want to manage GPU driver installation by their own. If not specified, the default is false. | ||
| - name: --driver-type | ||
| type: string | ||
| short-summary: Specify the type of GPU driver to install when creating Windows agent pools. Valid values are "GRID" and "CUDA". If not provided, AKS selects the driver based on system compatibility. This option cannot be changed once the AgentPool has been created. The default is system selected. |
There was a problem hiding this comment.
🔎
--driver-type should use backticks for the placeholders "GRID" and "CUDA" to clearly denote them as specific values:
- short-summary: Specify the type of GPU driver to install when creating Windows agent pools. Valid values are "GRID" and "CUDA".
+ short-summary: Specify the type of GPU driver to install when creating Windows agent pools. Valid values are `GRID` and `CUDA`. | node_public_ip_tags=None, | ||
| enable_artifact_streaming=False, | ||
| skip_gpu_driver_install=False, | ||
| driver_type=None, |
There was a problem hiding this comment.
🔎
Ensure the new parameter driver_type is documented and handled appropriately within the function. If driver_type needs validation or default values, add those. For example:
if driver_type is not None:
# Validate driver_type options or set default if needed
valid_driver_types = ['type1', 'type2']
if driver_type not in valid_driver_types:
raise ValueError(f"Invalid driver_type: {driver_type}. Must be one of {valid_driver_types}")| @@ -9,6 +9,10 @@ If there is no rush to release a new version, please just add a description of t | |||
There was a problem hiding this comment.
🔎
PR Summary:
- Added
--driver-typeparameter to theaz aks nodepool addcommand. - Updated relevant test cases to include
test_aks_gpu_driver_type. - Introduced constants for GPU driver types:
CONST_GPU_DRIVER_TYPE_CUDAandCONST_GPU_DRIVER_TYPE_GRID. - Implemented logic to handle the
--driver-typeparameter within the AKS agent pool configuration. - Updated documentation to reflect the new
--driver-typeoption. - Bumped the package version from
9.0.0b3to9.0.0b4.
|
Hi @AllyW
|
6113b84 to
7059eb5
Compare
efa1067 to
d508c9c
Compare
AllyW
pushed a commit
that referenced
this pull request
Oct 18, 2025
* add pester tests for k8s-extension * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Extend ContainerInsights Extension for high log scale mode support (#9) * update python version to 3.13 (#10) * add pester tests for k8s-extension * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Extend ContainerInsights Extension for high log scale mode support (#9) * update python version to 3.13 (#10) * update readme and version release notes (#12) * remove extension specific pester tests --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: bragi92 <kadubey@microsoft.com> Co-authored-by: Long Wan <wanlonghenry@gmail.com>
AllyW
pushed a commit
that referenced
this pull request
Oct 18, 2025
* add pester tests for k8s-extension * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Extend ContainerInsights Extension for high log scale mode support (#9) * update python version to 3.13 (#10) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Add k8s-extension troubleshoot phase 1: Infrastructure setup. (#11) * [k8s-extension] Update extension CLI to v1.7.0 (#13) * remove redundant test files --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: bragi92 <kadubey@microsoft.com> Co-authored-by: Long Wan <wanlonghenry@gmail.com> Co-authored-by: Andres Borja <76450334+andborja@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.