-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement alt_allele_prob option #142
Comments
@XingerTang - assigned to this issue. |
!!!This comment is DISCARDED Coding tasks to do:
|
I spoke with @AprilYUZhang today and she pointed out some bits that I wan't to clarify here. Current state in AlphaPeel is the following:
There are two issues with the above: The above suggests that we would like to end up in this "correct" state:
|
@gregorgorjanc Thank you for summarizing this! There is just one point I would like to clarify. In steps 2 and 3 of the "correct" state, you mentioned that we would update the estimation of alternative allele probability every peeling cycle, and use the updated allele probability to reestimate the anterior terms. But, we had a conversation about the information contained in the updated alternative allele probability, which is the same as the information contained in the anterior terms after each peeling cycle. If we reestimate anterior terms based on the updated alternative allele probability, it would be the same as the one before the reestimation. So we probably would only do the estimation at the very beginning of the whole peeling process for the peeling accuracy and the reestimation at the very end of the peeling process for the more accurate alternative allele probability output. |
@XingerTang right, I keep forgetting that with the addition of metafounders the founders of the new internal pedigree are the metafounders which are “parents” of all our actual founding individuals! Let’s see … so, these metafounders will have anterior, penetrance, and “posterior” terms. When we have a starting allele prob (passed by user or estimated from the data) we should use that for the anterior term of the metafounder(s). Then we peel down and up the pedigree. Once we come up, we will have estimated individual genotype probabilities for the metafounder(s) by combining the anterior and “posterior” terms (the “posterior” term will collect all the information from all descendants of each metafounder) while penetrance will always be unknown for metafounders (unless we have some prior information). These estimated individual genotype probabilities for the metafounder(s) are in fact estimated base population genotype probabilities and we can simply convert these to estimate the base population allele frequency (possibly for more than one metafounder). Having this estimate, we can update the anterior term of the metafounder(s) and repeat peeling down and up. There will be a cycle/loop of information flow so we will have to test how it works in terms of accuracy and runtime till convergence (we might need to add actual convergence metric!). How does this sound? |
@gregorgorjanc Sure, it sounds doable. |
@gregorgorjanc @AprilYUZhang @RosCraddock I just noticed a big issue behind our current implementation of the metafounder: In the old The problem is that even though the individuals may share the same alternative allele frequency, it doesn't mean that they can share their parents. For example, its possible for a locus of an individual to have a genotype One way to solve the problem is that generate a dummy individual for each of the cases a metafounder is used, the only known information now for those dummy individuals from the same metafounder is that they share the same alternative allele frequency and nothing more. |
A correction on the reason why individuals can't share their parents. The information of an individual may be passed to another unrelated individual through their fake common parent metafounder such that it would affect their genotype probability distributions during the peeling. |
@RosCraddock
|
@RosCraddock |
Thank you, Evie. I will make those changes over the next few days. For completeness of this issue, I will summarise the change in the approach and reasoning for doing so (i.e our meeting minutes from yesterday):
Solution: Hence, we decided not to create dummy individuals for the metafounders but to use the user-assigned metafounders as a tag for assigning the matching alternative allele frequency to the base (founder) individuals. This addresses the above two issues ensuring the metafounders only inform the alternative allele frequency and no assumed sibling relationships. Additionally, this solution will minimise storage use compared to others, hopefully maintaining AlphaPeel's runtimes. |
@RosCraddock @XingerTang with the pr #148 now merged in, please revise the tasks listed above. Are any tasks still outstanding? |
Thank you for merging, @gregorgorjanc! All tasks relating to pr #175 have been completed. However, some comments on this issue are still relevant for the second stage (i.e the estimation of the alternative allele frequency). |
So we can change allele freq in the founders (not setting to 0.5 and not estimating from the data)
The text was updated successfully, but these errors were encountered: