Skip to content

Commit

Permalink
fix(ui): show Jupyter badge only after notebook is running (reanahub#416
Browse files Browse the repository at this point in the history
)

Closes reanahub#408
  • Loading branch information
Alputer committed Jan 15, 2025
1 parent 77d55b7 commit 35c98b5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion reana-ui/src/actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ export function openInteractiveSession(id, options = {}) {
"Success!",
"The interactive session has been created. " +
"However, it could take several minutes to start the Jupyter Notebook. " +
"Click on the Jupyter logo to access it. " +
"Click on the Jupyter notebook badge to access it. " +
`${interactiveSessionInactivityWarning}`,
),
);
Expand Down
2 changes: 1 addition & 1 deletion reana-ui/src/components/WorkflowActionsPopup.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default function WorkflowActionsPopup({ workflow, className }) {
const isDeleted = status === "deleted";
const isDeletedUsingWorkspace = isDeleted && size.raw > 0;
const isRunning = status === "running";
const isSessionOpen = sessionStatus === "created";
const isSessionOpen = sessionStatus === "running";

let menuItems = [];

Expand Down
2 changes: 1 addition & 1 deletion reana-ui/src/components/WorkflowBadges.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default function WorkflowBadges({ workflow }) {
session_status: sessionStatus,
} = workflow;
const hasDiskUsage = size.raw > 0;
const isSessionOpen = sessionStatus === "created";
const isSessionOpen = sessionStatus === "running";

return (
<div className={styles.badgesContainer}>
Expand Down

0 comments on commit 35c98b5

Please sign in to comment.