Correct serviceOwner for legacy

[Andreass2]

Description

Now uses correct service owner for legacy correspondences.
MessageSender = messageSender, with fallback on names for Sender¨
ServiceOwner = name of the ServiceOwner

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)
• All tests run green

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

• New Features

  • Enhanced handling of party information with the introduction of the PartyInfo structure, improving clarity in correspondence management.

• Bug Fixes

  • Improved error logging for failed lookups of resource owners and recipients, enhancing traceability of issues.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces significant changes to the LegacyGetCorrespondencesHandler class, primarily focusing on the renaming of the internal record type from ResourceOwner to PartyInfo. This change modifies how party information is structured, with the new PartyInfo record incorporating an Id field instead of OrgNumber. Additionally, the handling of resource owners and recipients has been updated to use the new structure, enhancing error logging during party lookups and refining the Process method to align with these updates.

Changes

File Path	Change Summary
src/Altinn.Correspondence.Application/GetCorespondences/LegacyGetCorrespondencesHandler.cs	Renamed ResourceOwner to PartyInfo, updated fields and logic for handling party information, improved error logging during lookups.

Possibly related PRs

• Feature: Expand get legacy correspondence response model  #385: Modifies the LegacyGetCorrespondencesHandler class, directly related to party information handling.
• Legacy - authorize multiple recipients #388: Enhances logic for user authorization and recipient mapping in the LegacyGetCorrespondencesHandler.
• fix correct userparty #402: Adjusts the Process method in the LegacyGetCorrespondencesHandler, refining recipient addition.
• Add message sender to Legacy list request #409: Adds a MessageSender property to LegacyCorrespondenceItem, linking it to the changes in the main PR.
• Changes to legacy list operation #497: Improves access control logic and error handling in the LegacyGetCorrespondencesHandler.
• Legacy: fix authorize for write #498: Introduces a new property AuthorizedForWrite in LegacyCorrespondenceOverviewExt, relevant to authorization context.

Suggested labels

kind/bug, ignore-for-release

Suggested reviewers

• CelineTrammi

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)

src/Altinn.Correspondence.Application/GetCorespondences/LegacyGetCorrespondencesHandler.cs (1)

87-130: Consider parallel processing for party lookups.

The current implementation performs sequential lookups for senders, resource owners, and recipients. This could be optimized by running these lookups in parallel using Task.WhenAll().

Example refactoring:

var lookupTasks = await Task.WhenAll(
    GetSenderDetails(correspondences.Item1.Select(c => c.Sender).Distinct()),
    GetResourceOwnerDetails(correspondences.Item1.Select(c => c.ResourceId).Distinct()),
    GetRecipientDetails(correspondences.Item1.Select(c => c.Recipient).Distinct())
);

var (Senders, resourceOwners, recipientDetails) = (lookupTasks[0], lookupTasks[1], lookupTasks[2]);

private async Task<List<PartyInfo>> GetSenderDetails(IEnumerable<string> orgNrs)
{
    var results = new List<PartyInfo>();
    foreach (var orgNr in orgNrs)
    {
        try
        {
            var party = await _altinnRegisterService.LookUpPartyById(orgNr, cancellationToken);
            results.Add(new PartyInfo(orgNr, party));
        }
        catch (Exception e)
        {
            _logger.LogError(e, "Failed to lookup sender party for orgNr: {OrgNr}", orgNr);
            results.Add(new PartyInfo(orgNr, null));
        }
    }
    return results;
}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ef77efa and 528da95.

📒 Files selected for processing (1)

• src/Altinn.Correspondence.Application/GetCorespondences/LegacyGetCorrespondencesHandler.cs (4 hunks)

🔇 Additional comments (3)

src/Altinn.Correspondence.Application/GetCorespondences/LegacyGetCorrespondencesHandler.cs (3)

23-23: LGTM! Good refactoring of the record type.

The rename from ResourceOwner to PartyInfo and the change from OrgNumber to Id makes the type more generic and reusable across different contexts.

---

101-116: LGTM! Good error handling for resource owner lookups.

The implementation includes proper error handling with informative logging messages, making it easier to diagnose issues in production.

---

117-130: LGTM! Good error handling for recipient lookups.

The implementation includes proper error handling with informative logging messages, similar to the resource owner lookups.