Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust css data model root button #14072

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Nov 14, 2024

Description

Adapting the sizes in the heading row in the node panel so the buttons have the same size:

DEV:

This branch:

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (4d8c7e3) to head (8ff5a22).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14072   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files        1763     1763           
  Lines       23000    23000           
  Branches     2676     2676           
=======================================
  Hits        21915    21915           
  Misses        836      836           
  Partials      249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@standeren standeren added skip-releasenotes Issues that do not make sense to list in our release notes team/studio-domain1 skip-manual-testing PRs that do not need to be tested manually skip-documentation Issues where updating documentation is not relevant labels Nov 14, 2024
@standeren standeren added the ux UX help needed label Nov 14, 2024
@TomasEng
Copy link
Contributor

Hvordan vil dette se ut når rotnoden er valgt? Og er ikonene fortsatt på linje med hverandre? Er overskriften godt nok fremhevet når den har samme størrelse som øvrig tekst?

@TomasEng
Copy link
Contributor

TomasEng commented Nov 18, 2024

Dette bør også koordineres med #13786.

@TomasEng TomasEng added added-to-sprint and removed skip-manual-testing PRs that do not need to be tested manually labels Nov 18, 2024
@standeren
Copy link
Contributor Author

Hvordan vil dette se ut når rotnoden er valgt? Og er ikonene fortsatt på linje med hverandre? Er overskriften godt nok fremhevet når den har samme størrelse som øvrig tekst?

Veldig godt poeng - hadde jeg ikke tenkt på! Har oppdatert koden nå. Men om du ikke mener dette er en god endring så kan vi lukke den. Jeg bare trodde det var en feil at denne knappen var større enn andre knapper.

@standeren
Copy link
Contributor Author

standeren commented Nov 19, 2024

Dette bør også koordineres med #13786.

Veldig sant! Skal pinge @ErlingHauan angående den saken 😬
EDIT: Har forhørt meg med han, og denne PRen vil ikke kollidere i det minste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint area/data-modeling Area: Related to data models - e.g. create, edit, use data models. frontend skip-documentation Issues where updating documentation is not relevant skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1 ux UX help needed
Projects
Status: 🔎 Review
Development

Successfully merging this pull request may close these issues.

2 participants