Skip to content

Improve InstanceResponse XML doc #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

Improve InstanceResponse XML doc #1232

merged 2 commits into from
Apr 7, 2025

Conversation

martinothamar
Copy link
Contributor

Description

Improve InstanceResponse XML doc

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@martinothamar martinothamar added ignore-for-release backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels Apr 4, 2025
@martinothamar martinothamar self-assigned this Apr 4, 2025
@martinothamar martinothamar requested a review from ivarne April 4, 2025 06:06
@martinothamar martinothamar moved this to 👷 In Progress in Team Apps Apr 4, 2025
@martinothamar martinothamar moved this from 👷 In Progress to 🔎 Review in Team Apps Apr 4, 2025
@ivarne
Copy link
Member

ivarne commented Apr 7, 2025

Looks good, but needs to accept changes to openApi specification.

@ivarne ivarne enabled auto-merge (squash) April 7, 2025 07:15
@ivarne ivarne merged commit cadd7ac into main Apr 7, 2025
9 checks passed
@ivarne ivarne deleted the chore/instanceresponse-xmldoc branch April 7, 2025 07:17
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Apps Apr 7, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@martinothamar martinothamar moved this from 🧪 Test to ✅ Done in Team Apps Apr 7, 2025
olamathiesenBlueTree pushed a commit to olamathiesenBlueTree/fork-altinn-app-lib-dotnet that referenced this pull request Apr 8, 2025
@martinothamar @ivarne @olamathiesenBlueTree
Improve InstanceResponse XML doc (Altinn#1232)
9992c5f 
* Improve 'InstanceResponse' XML doc

* Accept changes to swager documnetation

---------

Co-authored-by: Ivar Nesje <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarne ivarne ivarne approved these changes

Assignees

@martinothamar martinothamar

Labels
backport-ignore This PR is a new feature and should not be cherry-picked onto release branches ignore-for-release
Projects
Team Apps
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinothamar @ivarne