fix(cors): update CORS methods to include OPTIONS and adjust header s…

…yntax
Alwatr · Nov 11, 2024 · 0ec647b · 0ec647b
1 parent 6ace201
commit 0ec647b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/nginx-core/Dockerfile b/nginx-core/Dockerfile
@@ -25,7 +25,7 @@ ENV NGINX_ACCESS_LOG="/var/log/nginx/access.log json" \
     NGINX_ENTRYPOINT_QUIET_LOGS="" \
     NGINX_CORS_ENABLE="" \
     NGINX_CORS_ORIGIN="*" \
-    NGINX_CORS_METHODS="GET" \
+    NGINX_CORS_METHODS="GET, OPTIONS" \
     NGINX_CORS_HEADERS="*" \
     NGINX_CORS_MAXAGE=86400
 

diff --git a/nginx-core/etc/nginx/templates/location.d/root.d/10-cors.conf.template b/nginx-core/etc/nginx/templates/location.d/root.d/10-cors.conf.template
@@ -1,14 +1,14 @@
-add_header 'Access-Control-Allow-Origin' $NGINX_CORS_ORIGIN;
-add_header 'Access-Control-Allow-Methods' $NGINX_CORS_METHODS;
-add_header 'Access-Control-Allow-Headers' $NGINX_CORS_HEADERS;
-add_header 'Access-Control-Max-Age' $NGINX_CORS_MAXAGE;
+add_header 'Access-Control-Allow-Origin' '$NGINX_CORS_ORIGIN';
+add_header 'Access-Control-Allow-Methods' '$NGINX_CORS_METHODS';
+add_header 'Access-Control-Allow-Headers' '$NGINX_CORS_HEADERS';
+add_header 'Access-Control-Max-Age' '$NGINX_CORS_MAXAGE';
 
 # Handle OPTIONS requests (preflight requests for complex requests)
 if ($request_method = 'OPTIONS') {
-  add_header 'Access-Control-Allow-Origin' $NGINX_CORS_ORIGIN;
-  add_header 'Access-Control-Allow-Methods'  $NGINX_CORS_METHODS;
-  add_header 'Access-Control-Allow-Headers' $NGINX_CORS_HEADERS;
-  add_header 'Access-Control-Max-Age' $NGINX_CORS_MAXAGE;
+  add_header 'Access-Control-Allow-Origin' '$NGINX_CORS_ORIGIN';
+  add_header 'Access-Control-Allow-Methods'  '$NGINX_CORS_METHODS';
+  add_header 'Access-Control-Allow-Headers' '$NGINX_CORS_HEADERS';
+  add_header 'Access-Control-Max-Age' '$NGINX_CORS_MAXAGE';
   add_header 'Content-Type' 'text/plain charset=UTF-8';
   add_header 'Content-Length' 0;