-
Notifications
You must be signed in to change notification settings - Fork 0
Issue 43 Caching Market API calls - AdSlot & AdUnits #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
elpiel
wants to merge
16
commits into
master
Choose a base branch
from
issue-43-caching-market-api-calls
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpiel
commented
Feb 15, 2021
src/market/cache.rs
Outdated
pub trait ClientLike<K> { | ||
type Output: Send + 'static; | ||
|
||
async fn get_fresh<'a>(&self, key: K) -> Self::Output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just couldn't figure out a way for K
to be able to support owned and reference values... I've tried mimicking DashMap
and HashMap
, but I got beaten by async
and the async_trait
crate
market - ad_unit cache market - ad_slot cache
- Caches - struct for holding all the different Cache structs - fix all occurrences of the Cache & use the newly created caches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #43
CHANGELOG:
MarketApi
is now wrapped in anArc
for cheap cloningGeneric
Cache
implementation for caching records for/units-for-slot
routeCache
(mod supermarket::cache::market
), caching the following calls:GET AdSlot
from Market -mod supermarket::cache::market::ad_slot
type AdSlotCache = Cache
impl ClientLike for AdSlotClient
with calls via theMarketApi
GET AdUnit
from Market (AdSlot
's fallback unit) -mod supermarket::cache::market::ad_unit
type AdUnitsCache = Cache
impl ClientLike for AdUnitsClient
with calls via theMarketApi
GET AdUnits
(fetched byAd Type
from the Market) -mod supermarket::cache::market::ad_unit
type AdTypeCache
type AdTypeCache = Cache
impl ClientLike for AdTypeClient
with calls via theMarketApi
mod supermarket::cache
moved tosupermarket::cache::campaign
- theCache
implementation forCampaign
s is now moved to separate, own modulestruct Caches
(mod supermarket::cache
) implementation that contains all the cache implementations in 1 structTODOs:
struct Caches
AdSlotCache
,AdUnitsCache
,AdTypeCache
AdSlotClient
,AdUnitsClient
&AdTypeClient
instead of mocking the API calls in/units-for-slot
tests (units_for_slot_tests.rs
)