Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitignore #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add gitignore #12

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 4, 2017

Prevent stupid things being committed into module repos.

@ghost ghost requested a review from rhodimus July 4, 2017 13:25
@ghost
Copy link
Author

ghost commented Jul 4, 2017

@rhodimus: Not sure if there's any other bits we might need to ignore, this is all I've found so far.

@claire-codes
Copy link
Contributor

@jakestubbz npm-debug.log?

@ghost
Copy link
Author

ghost commented Jul 4, 2017

@rhodimus: Should this include view/frontend/web/js/dist too?

@ghost
Copy link
Author

ghost commented Jul 13, 2017

Discussed with Rhod - this needs to be an option when running the generator (i.e. "Do you want a .gitignore file?"), as it's not always going to be required if running in app/code for example

@ghost ghost self-assigned this Jul 13, 2017
@ghost ghost added the work in progress label Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants