Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previously existing bookmark highlight range adjustment #1079

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tuomas2
Copy link
Contributor

@tuomas2 tuomas2 commented May 20, 2021

Closes #1078

@tuomas2
Copy link
Contributor Author

tuomas2 commented May 20, 2021

Can't figure out how to trigger floating action mode (which also makes range adjustment handles visible) from code.

@tuomas2
Copy link
Contributor Author

tuomas2 commented May 20, 2021

@agrogers
Copy link
Contributor

agrogers commented Sep 15, 2021

What if you did it this way:

  1. Select a range using the long click method
  2. Add an additional option to the pop up menu called 'Change Bookmark'
  3. Throw up a dialog that lists all the bookmarks that the range touches.
  4. Let the user choose the bookmark they want to adjust and simply update the range for that bookmark based on the new selection.
  5. The dialog might need an option to specify if the selection applies to just the selected text or to the verses the selected text covers. You could add that as another menu option in the popup menu but that menu is not beautiful and adding more options would make it even less beautiful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Prio 6
Development

Successfully merging this pull request may close these issues.

Adjust bookmark's highlight range afterwards
2 participants