Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for valid JSON content in addition to mime type #8

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

debakarr
Copy link

@debakarr debakarr commented Nov 1, 2023

Some site like this: https://bmtcwebportal.amnex.com/commuter/dashboard does not have mime type set to JSON but they still have the content of API response as JSON.

Here I am additionally adding condition to validate in case the mime type is not JSON, we validate that the response body also is not JSON.

@AndrewWalsh
Copy link
Owner

Thanks for raising this PR @debakarr, good catch. I'll include this in the next release 👍 .

@AndrewWalsh AndrewWalsh merged commit e5d4e59 into AndrewWalsh:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants