test: tests for nine more proxies #2467
Conversation
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
src/ape_ethereum/ecosystem.py
Outdated
| ProxyType.ZeroAge: r"^3d3d3d3d363d3d37363d73(.{40})5af43d3d93803e602a57fd5bf3", | ||
| ProxyType.Clones: r"^36603057343d52307f830d2d700a97af574b186c80d40429385d24241565b08a7c559ba283a964d9b160203da23d3df35b3d3d3d3d363d3d37363d73(.{40})5af43d3d93803e605b57fd5bf3", | ||
| ProxyType.Vyper: r"^366000600037611000600036600073(.{40})5af4602c57600080fd5b6110006000f3", |
There was a problem hiding this comment.
I removed this because it never matched -- always matched Minimal... I think that makes sense though.
Same with Solady-- they are both just efficient ways of getting minimal proxies.
antazoey
force-pushed
the
add_proxies_test
branch
4 times, most recently
from
63b8d30 to
752c14d
Compare
antazoey
force-pushed
the
add_proxies_test
branch
from
752c14d to
0cabd90
Compare
|
More work / research needed, but didn't want to lose the valid tests you added, so i just chopped off the troublesome parts for now so we can merge this. Feel free to return on a new PR to complete more! Thank you for the contrib ◡̈ |
|
i'm baffled by the error, i dont get it locally... my guess it is somehow related to github-action caching but can't figure out how it would have the test file changes but not the test contract's. |
What I did
This PR adds to #760 tests for the following proxies:
The tests for the following proxies failed: SoladyCWIA, SplitsCWIA,Vyper and OldCWIA. The pattern that the function
get_proxy_infotries to identify can not be found in the proxy bytecode after compilation. I am unsure whether the issue lies in the compilation (perhaps optimizations are altering the bytecode) or if I am using the wrong proxy for the test. Something weird happens with two of them ( Vyper and SoladyCWIA),they are identified as Minimal proxies.Regarding the other proxies (VyperBeta, and ZeroAge), I cannot find the test code for these proxies. Could you assist me with that?
fixes: #760