Skip to content

test: use our ApeWorX action in tests #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025
Merged

Conversation

antazoey
Copy link
Member

What I did

This helps us so much. Benefits:

  • We are always ensuring our github action works (testing goes both ways)
  • We can now use actual compilers in Ape's test, get to delete a lot of annoying test artifacts, hence the high deleted lines of code in this PR
  • Can use dependencies easier, since those get cached now.
  • Allows us to more easily migrate the tests from ape-titanoboa to core, something im working on

How I did it

How to verify it

Checklist

  • All changes are completed
  • Change is covered in tests
  • Documentation is complete

fubuloubu
fubuloubu previously approved these changes Feb 17, 2025
@antazoey antazoey force-pushed the test/ape branch 2 times, most recently from 6aba65b to ff9b352 Compare February 18, 2025 16:23
@antazoey antazoey marked this pull request as ready for review March 14, 2025 15:32
fubuloubu
fubuloubu previously approved these changes Mar 15, 2025
@antazoey
Copy link
Member Author

blocked by #2551
(and probably more)

@antazoey
Copy link
Member Author

hoist: #2552

@antazoey
Copy link
Member Author

found another bug: #2555

@antazoey antazoey force-pushed the test/ape branch 3 times, most recently from 750afac to d4f1b63 Compare March 21, 2025 16:47
@antazoey antazoey force-pushed the test/ape branch 6 times, most recently from 9065b41 to df8b646 Compare April 25, 2025 13:33
@antazoey antazoey force-pushed the test/ape branch 2 times, most recently from ae1c07e to c655132 Compare April 25, 2025 20:13
fubuloubu
fubuloubu previously approved these changes Apr 25, 2025
Copy link

github-actions bot commented Jun 1, 2025

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

@github-actions github-actions bot added the stale No activity for 30 days label Jun 1, 2025
@fubuloubu fubuloubu removed the stale No activity for 30 days label Jun 1, 2025
fubuloubu
fubuloubu previously approved these changes Jun 27, 2025
@antazoey
Copy link
Member Author

note that it is a smidge slower when it has to compile, but when the compile cache works, it seems just as fast as it was before (test tests)... and i can probably improve it when i have time, maybe splitting the contracts up into different projects

@antazoey antazoey merged commit 45a6155 into ApeWorX:main Jun 27, 2025
18 checks passed
@antazoey antazoey deleted the test/ape branch June 27, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants