-
-
Notifications
You must be signed in to change notification settings - Fork 172
feat(config): support deterministic addresses in config #2593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(config): support deterministic addresses in config #2593
Conversation
3b20684 to
e3cf68b
Compare
antazoey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, but see comments! you'll like some of the feedback I think
Note on the tests: macos is currently failing occasionally on the gas flag integration tests, I'm looking into it now.. As long the Ubunutu's pass, can merge
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
|
This PR was closed because it has been inactive for 35 days. |
af2b8c5 to
cf5e573
Compare
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
cf5e573 to
e66f451
Compare
Co-authored-by: antazoey <[email protected]>
What I did
Support deterministic address config
fixes: #2590
How I did it
Add deterministic
DeploymentConfigobjects to every networkHow to verify it
See issue
Checklist