Skip to content

Conversation

@fubuloubu
Copy link
Member

What I did

Support deterministic address config

fixes: #2590

How I did it

Add deterministic DeploymentConfig objects to every network

How to verify it

See issue

Checklist

  • All changes are completed
  • Change is covered in tests
  • Documentation is complete

@fubuloubu fubuloubu requested a review from antazoey April 30, 2025 22:35
@fubuloubu fubuloubu force-pushed the feat/config-deterministic-addresses branch from 3b20684 to e3cf68b Compare May 1, 2025 00:10
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but see comments! you'll like some of the feedback I think

Note on the tests: macos is currently failing occasionally on the gas flag integration tests, I'm looking into it now.. As long the Ubunutu's pass, can merge

@github-actions
Copy link

github-actions bot commented Jun 2, 2025

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

@github-actions github-actions bot added the stale No activity for 30 days label Jun 2, 2025
@fubuloubu fubuloubu removed the stale No activity for 30 days label Jun 2, 2025
antazoey
antazoey previously approved these changes Jun 2, 2025
@github-actions
Copy link

github-actions bot commented Jul 3, 2025

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

@github-actions github-actions bot added the stale No activity for 30 days label Jul 3, 2025
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

This PR was closed because it has been inactive for 35 days.

@github-actions github-actions bot added the inactive no recent activity, closed label Jul 8, 2025
@github-actions github-actions bot closed this Jul 8, 2025
@fubuloubu fubuloubu removed stale No activity for 30 days inactive no recent activity, closed labels Jul 12, 2025
@fubuloubu fubuloubu reopened this Jul 12, 2025
@fubuloubu fubuloubu force-pushed the feat/config-deterministic-addresses branch from af2b8c5 to cf5e573 Compare July 14, 2025 19:11
@github-actions
Copy link

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

@github-actions github-actions bot added the stale No activity for 30 days label Aug 14, 2025
@fubuloubu fubuloubu removed the stale No activity for 30 days label Aug 14, 2025
@github-actions
Copy link

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

@github-actions github-actions bot added the stale No activity for 30 days label Sep 14, 2025
@fubuloubu fubuloubu removed the stale No activity for 30 days label Sep 15, 2025
@github-actions
Copy link

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

@github-actions github-actions bot added the stale No activity for 30 days label Oct 16, 2025
@fubuloubu fubuloubu removed the stale No activity for 30 days label Oct 16, 2025
@fubuloubu fubuloubu self-assigned this Nov 14, 2025
@fubuloubu fubuloubu requested a review from antazoey November 19, 2025 21:26
@fubuloubu fubuloubu enabled auto-merge (squash) November 19, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow specifying deterministic deployments via single address

2 participants