-
-
Notifications
You must be signed in to change notification settings - Fork 160
feat(AccountAPI): show deployment address before broadcast #2653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(AccountAPI): show deployment address before broadcast #2653
Conversation
Working on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you post a printout of what this looks like (for both account.deploy and
contract.deplpy`)
Done |
src/ape/contracts/base.py
Outdated
# TODO: Not possible method not available | ||
|
||
if "sender" in kwargs: | ||
possible_address = kwargs["sender"].get_deployment_address() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically sender can be an address type here still
What I did
fixes: #2596
How I did it
How to verify it
Put the following contract into the
contracts
folderPut the following test script in the
scripts
folderThe output
Checklist