Skip to content

Conversation

@pwright
Copy link
Contributor

@pwright pwright commented May 29, 2025

reduces file count in main docs.

reversible (to a point) using https://gist.github.com/pwright/452af3d29599a9f81909a2de10e20c4d

which is a rewrite for simplicity of https://github.com/redhat-documentation/nebel

  • does not require annotation
  • does not categorize modules (change ids to workaround)
  • does not require nebel.cfg

@pwright pwright requested a review from EricWittmann May 29, 2025 14:44
@pwright pwright marked this pull request as draft May 29, 2025 15:13
@pwright
Copy link
Contributor Author

pwright commented May 29, 2025

@EricWittmann returning to draft status, spotted some small issues

@pwright pwright marked this pull request as ready for review May 29, 2025 18:09
@pwright
Copy link
Contributor Author

pwright commented May 29, 2025

@EricWittmann given the size of the change here, could i ask you to test this way: compare the html from build of main with html from this branch.. there should be no diffs. is that reasonable?

@EricWittmann
Copy link
Member

@pwright I have done the comparison and (other than some timestamps) there were no differences. I'm 👍 to merge this if you are.

Copy link
Member

@EricWittmann EricWittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pwright pwright enabled auto-merge (squash) June 3, 2025 14:01
@pwright
Copy link
Contributor Author

pwright commented Jun 3, 2025

@EricWittmann couldyou merge please?

@EricWittmann EricWittmann disabled auto-merge June 3, 2025 15:42
@EricWittmann EricWittmann merged commit bdf31ba into Apicurio:main Jun 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants