fix: Add primary keys to label tables for MySQL InnoDB Cluster compatibility #6867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibility Adds composite primary keys to three label tables (group_labels, artifact_labels, and version_labels) across all database types (MySQL, PostgreSQL, H2, and MSSQL). MySQL InnoDB Cluster requires all tables to have primary keys defined. The missing primary keys prevented cluster initialization from completing. The primary keys are based on the natural keys of each table: - group_labels: (groupId, labelKey) - artifact_labels: (groupId, artifactId, labelKey) - version_labels: (globalId, labelKey) This change only affects new installations. Existing deployments will continue to function without these primary keys, as they are not functionally required by the application logic. Fixes #6865 Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds composite primary keys to three label tables (
group_labels,artifact_labels, andversion_labels) across all database types (MySQL, PostgreSQL, H2, and MSSQL) to enable MySQL InnoDB Cluster compatibility.Changes
(groupId, labelKey)(groupId, artifactId, labelKey)(globalId, labelKey)Rationale
MySQL InnoDB Cluster requires all tables to have primary keys defined. The missing primary keys on these three label tables prevented cluster initialization from completing successfully.
The chosen composite keys are based on the natural keys of each table - the foreign key column(s) plus
labelKey- which prevents duplicate label keys for the same entity (group/artifact/version) as expected by the application logic.Impact
Testing
The primary keys enforce the existing application behavior where each entity can only have one value per label key, which is already enforced by the
DELETE+INSERTpattern used in the code.Fixes #6865