-
Notifications
You must be signed in to change notification settings - Fork 308
Simplify Apicurio Registry upstream testing strategy #6970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Apicurio Registry upstream testing strategy #6970
Conversation
fe3d3a4 to
0499990
Compare
2842f75 to
1332240
Compare
b8682d7 to
ec58712
Compare
7e230e3 to
f47173f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not need to be committed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but if you read it, you'll get a much better idea of what's going on. I'm going to update the PR description with this.
|
This is pretty big. I trust you if this works, is there anything in particular that you want opinion on? |
About the approach itself. I'm not asking for a full review of the thing :) The TLDR is essentially the following:
|
EricWittmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve in principal. :) Happy to have it merged and we can see how it goes and fix/iterate if needed.
|
I'm a big fan of reusable workflows and matrix execution.... I want to do that in apicurio-testing as well. So thumbs up from me! We definitely accumulated some unnecessary complexity over time. Additional note: I don't see any changes to the operator workflows, correct? Because they aren't going to run in this PR unless there's a change in the operator dir. |
9a42300 to
fbe589a
Compare
Correct, this is simplifying the workflows and remove some unused ones, like the RHBOQ one. Regarding the operators, the only change is to re-use the slack notification one, that was replicated across the different ones, and one it's simplifies into a single, parametrized one. |
|
All the workflows are green. I'm merging this and we can continue iterating on it. This is the first round to improve our processes. I'm also trying to improve the speed, ~30min is way too much. |
* Run app tests in parallel using surefire forks * Simplify workflows * Re-use workflows * Move reusable workflows to top directory * Split verification process into multiple processes * Build application first and run tests in parallel * Do not build or run in parallel * Split native workflow Implement authentication for the mcp server
* Run app tests in parallel using surefire forks * Simplify workflows * Re-use workflows * Move reusable workflows to top directory * Split verification process into multiple processes * Build application first and run tests in parallel * Do not build or run in parallel * Split native workflow Implement authentication for the mcp server
Summary
This PR simplifies and optimizes the Apicurio Registry CI/CD pipeline by restructuring the verification workflows into a modular, parallel architecture.
Changes
Test plan