[Search Improvements] Phase 1: Query Optimization #7072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlesarnal
force-pushed
the
issue-7010-search-query-optimization
branch
3 times, most recently
from
6902f30 to
234bf56
Compare
This commit implements Phase 1 of the search query optimization work for issue Apicurio#7010. Key optimizations: - Use window functions (COUNT(*) OVER()) to combine result and count queries into a single query - Keep EXISTS subqueries for label filtering (compatible with all database backends) - Add composite indexes on label tables for PostgreSQL, SQL Server, and H2 Changes include: - New mapper classes for handling window function results (SearchedArtifactWithCountMapper, SearchedVersionWithCountMapper, SearchedGroupWithCountMapper) - Extended SqlStatements interface with window function template methods - Refactored searchArtifacts(), searchVersions(), and searchGroups() methods - DDL upgrade scripts for v102 schema with composite indexes - Note: MySQL does not include composite indexes due to 3072-byte key length limit Closes Apicurio#7010
carlesarnal
force-pushed
the
issue-7010-search-query-optimization
branch
from
234bf56 to
d72b745
Compare
carlesarnal
added a commit
that referenced
this pull request
Jan 8, 2026
…)" This reverts commit f6070f2.
carlesarnal
added a commit
that referenced
this pull request
Jan 8, 2026
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
COUNT(*) OVER()) to combine result and count queries into a single database queryRoot Cause
Search operations were executing two separate queries: one for fetching results and one for counting total matches. This doubled the database round-trips for every search operation.
Changes
SearchedArtifactWithCountMapper,SearchedVersionWithCountMapper,SearchedGroupWithCountMapper)SqlStatementsinterface withselectWithCountWindowTemplate()methodsearchArtifacts(),searchVersions(), andsearchGroups()methods to use single combined queriesTest plan
Closes #7010