fix: replace printStackTrace() calls with proper logging #7073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace all printStackTrace() calls with proper SLF4J logging throughout the codebase: - Production code: Use log.error(), log.warn(), or log.debug() as appropriate - Test code: Use logger from base class or add SLF4J logger - Examples: Use System.err.println() for standalone demo apps - Build tools: Add SLF4J logging Also added slf4j-api dependency to schema-resolver module. Fixes Apicurio#7070
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
printStackTrace()calls with proper SLF4J logging throughout the codebaseslf4j-apidependency to schema-resolver moduleRoot Cause
The codebase contained 18
printStackTrace()calls across 13 files, which is not a best practice as it outputs to stderr without proper log formatting, levels, or integration with the logging infrastructure.Changes
Production code:
ERCache.java: Added SLF4J logger, replaced withlog.error()andlog.debug()GraphQLContentValidator.java: Added SLF4J logger, replaced withlog.debug()schema-resolver/pom.xml: Addedslf4j-apidependencyTest code:
SimpleAuthIT.java: Replaced withlogger.warn()(using base class logger)MigrationTestsDataInitializer.java: Added logger, replaced withlog.error()GenerateCanonicalHashImportIT.java: Added logger, replaced withlog.error()ImportExportTest.java: Added logger, replaced withlog.warn()andlog.debug()AllYamlTest.java: Added logger, replaced withlog.error()TestUtils.java: Replaced withlog.warn()Examples:
SimpleBroker.java: Replaced withSystem.err.println()MessagePublisher.java: Removed redundantprintStackTrace()(message already printed)MtlsClientDemo.java: Replaced with structured error outputBuild tools:
GenerateAllConfigPartial.java: Added logger, replaced 4 calls with proper loggingTest plan
printStackTrace()calls (except auto-generated MavenWrapperDownloader.java)Fixes #7070