-
-
Notifications
You must be signed in to change notification settings - Fork 418
chore: use mapping syntax instead of sequence syntax #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request updates the Docker Compose files to use the mapping syntax ( No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Marukome0743 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Thanks for the detailed explanation of why the mapping syntax is preferred.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
b2f723a
to
9d8f0d8
Compare
64bad04
to
e437014
Compare
14c6372
to
18d14bb
Compare
8087f08
to
080f025
Compare
5099f94
to
655e1ef
Compare
c112d5a
to
0146efc
Compare
fc39a65
to
8c9d10d
Compare
3d38082
to
c5134d9
Compare
Description
This PR changes the environment variables style on compose.yaml file.
The new
FOO: BAR
mapping syntax is prefer to- FOO=BAR
sequence syntax at 2 points.Fragments
First mapping syntax can use Fragments.
Readable in IDE
The above images are Visual Studio Code.
The sequence syntax shows the all orange color environment variables.
On the other hand, the mapping syntax divides them into blue and orange color texts.
Therefore you can read them using
FOO: BAR
mapping syntax easily.In conclusion,
FOO: BAR
mapping syntax is better than- FOO=BAR
sequence syntax.Summary by Sourcery
Update Docker Compose environment variable syntax from sequence to mapping style
Enhancements:
Chores:
- FOO=BAR
) to mapping style (FOO: BAR
) across multiple Docker Compose configuration files