-
-
Notifications
You must be signed in to change notification settings - Fork 418
fix: update ai environment variables #1331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request updates the AI environment variables in No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Marukome0743 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining the purpose of the
SUPPORT_OPENAI_V3_IMAGE_MODEL
environment variable.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- ANTHROPIC_API_KEY=${AI_ANTHROPIC_API_KEY} | ||
- AI_AWS_ACCESS_KEY_ID=${APPFLOWY_S3_ACCESS_KEY} | ||
- AI_AWS_SECRET_ACCESS_KEY=${APPFLOWY_S3_SECRET_KEY} | ||
- AI_APPFLOWY_BUCKET_NAME=${AI_APPFLOWY_BUCKET_NAME} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will need to check if these env variable are being used at all.
6c12e3f
to
dd77e7b
Compare
While the variables were renamed in the PR, they are applicable to the private AppFlowy AI image used by our managed service, rather than the public AppFlowy AI image which is available for self hosters. You would see, that the image on docker compose CI is actually different from the one in docker compose. One has the premium suffix, the other one doesn't. Nevertheless, these inconsistencies are indeed confusing. So we might update the current public AppFlowy AI image to adopt the same env variable as the premium variant. |
e0c4d35
to
44b9de9
Compare
2c9c4c4
to
bed752a
Compare
2536a7d
to
debcba5
Compare
bb0e5e7
to
0047db2
Compare
8b0165e
to
83ab120
Compare
eb03a80
to
2e7b645
Compare
Summary
At #1133, some ai environment variables are renamed.
This PR updates them and add the missing ones in docker-compose.yml and docker-compose-ci.yml.
Summary by Sourcery
Update AI service environment variables in docker-compose.yml to support additional configuration options
Enhancements:
Deployment: