Skip to content

fix: Add postgres envvar to dev.env #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vincent-lau
Copy link

@Vincent-lau Vincent-lau commented Jul 19, 2025

The postgres envvar is missing in the dev.env, and this results in postgres' health check failing as it uses these envvars. this makes the health check default envvar like POSTGRES_USER to blank string. For some reason it is not enough just to specify them in the environment section of the docker compose file so add these to dev.env just like deploy.env

Summary by Sourcery

Bug Fixes:

  • Include Postgres env vars (e.g., POSTGRES_USER) in dev.env to prevent blank defaults and health check failures

The postgres envvar is missing in the dev.env, and this results in
postgres' health check failing as it uses these envvars. this makes the
health check default envvar like `POSTGRES_USER` to blank string.
For some reason it is not enough just to specify them in the environment
section of the docker compose file so add these to dev.env just like
deploy.env
Copy link

sourcery-ai bot commented Jul 19, 2025

Reviewer's Guide

This PR ensures the PostgreSQL health check has the required credentials by copying the missing environment variables from deploy.env into dev.env.

File-Level Changes

Change Details Files
Add missing Postgres environment variables to dev.env
  • Added POSTGRES_USER
  • Added POSTGRES_PASSWORD
  • Added POSTGRES_DB
dev.env

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Vincent-lau - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants