Skip to content

fix: launch review 0.5.9#5443

Merged
Xazin merged 15 commits intoAppFlowy-IO:mainfrom
Xazin:fix/launch-review-0.5.9
Jun 2, 2024
Merged

fix: launch review 0.5.9#5443
Xazin merged 15 commits intoAppFlowy-IO:mainfrom
Xazin:fix/launch-review-0.5.9

Conversation

@Xazin
Copy link
Contributor

@Xazin Xazin commented May 30, 2024

Relates: #4970 #5434

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@Xazin Xazin requested a review from LucasXu0 May 30, 2024 11:33
@github-actions
Copy link

github-actions bot commented May 30, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 26 warning contribute (via Fink 🐦)

@LucasXu0 LucasXu0 added bug Something isn't working v0.5.9 labels May 31, 2024
@LucasXu0
Copy link
Collaborator

The AFFocusManager is not registered in the test environment, which causes tests to fail. If it's not required in the test environment, I think we can use maybeOf instead.

@Xazin Xazin merged commit 4ad7c48 into AppFlowy-IO:main Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working v0.5.9

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants