Skip to content

chore: enable integration test on windows #7658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Mar 31, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Extend integration testing to support Windows and macOS platforms in addition to Linux

CI:

  • Update GitHub Actions workflow to add integration test jobs for Windows and macOS
  • Modify flutter integration test action to support multi-platform testing with platform-specific configuration

Copy link
Contributor

sourcery-ai bot commented Mar 31, 2025

Reviewer's Guide by Sourcery

This pull request enables integration tests on Windows and macOS platforms, expanding the testing coverage beyond Linux. It introduces new jobs in the CI workflow for Windows and macOS, and modifies the flutter integration test action to handle platform-specific configurations and dependencies.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Enabled integration tests for Windows and macOS in the CI workflow.
  • Added new jobs windows_integration_test and macos_integration_test to the workflow.
  • Configured the jobs to run on Windows and macOS runners respectively.
  • Defined a matrix strategy to run multiple tests in parallel on each platform.
  • Utilized the existing flutter_integration_test action for running the tests.
.github/workflows/flutter_ci.yaml
Modified the flutter_integration_test action to support Windows and macOS.
  • Added conditional logic to install platform-specific prerequisites.
  • Enabled Flutter desktop support for Windows and macOS.
  • Added conditional logic to download artifacts based on the runner OS.
  • Added conditional logic to run flutter tests based on the runner OS.
.github/actions/flutter_integration_test/action.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LucasXu0 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a matrix strategy for the OS in the flutter_integration_test action to avoid repetition.
  • The conditional artifact downloads in flutter_integration_test/action.yml seem redundant, as the action already knows the runner OS.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LucasXu0 LucasXu0 force-pushed the enable_ci_on_windows_linux_2 branch 2 times, most recently from 0471f36 to b6da597 Compare March 31, 2025 08:14
@LucasXu0 LucasXu0 force-pushed the enable_ci_on_windows_linux_2 branch from b6da597 to ce91b0c Compare March 31, 2025 08:14
@LucasXu0 LucasXu0 force-pushed the enable_ci_on_windows_linux_2 branch from 76203d7 to 3d3b2b3 Compare April 2, 2025 05:29
@LucasXu0 LucasXu0 force-pushed the enable_ci_on_windows_linux_2 branch 3 times, most recently from 1e1930a to c29d1d0 Compare April 11, 2025 10:02
@LucasXu0 LucasXu0 force-pushed the enable_ci_on_windows_linux_2 branch from c29d1d0 to befb8d1 Compare April 11, 2025 13:30
@LucasXu0 LucasXu0 changed the title chore: enable integration test on windows and linux chore: enable integration test on windows Apr 14, 2025
LucasXu0 and others added 6 commits April 15, 2025 10:13
* fix: unable to accpet 'make it longer'

* fix: markdown text robot test
* fix: add error text under text field

* chore: update translation
* fix: some link_preview launch review issues

* fix: some UI issues

* chore: pasting a link will not check whether it is an image

* fix: copy link to block not supported well

* fix: mention UI issues

* feat: support get youtube channel info

* chore: update translation

* feat: add shadow in appflowy theme

* chore: remove AFThemeExtensionV2

* fix: some UI issues
* feat: update i18n and icons

* chore: replace appflowy with welcome to appflowy

* fix: protenial delete page error

* fix: flutter analyze
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants