-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore: enable integration test on windows #7658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request enables integration tests on Windows and macOS platforms, expanding the testing coverage beyond Linux. It introduces new jobs in the CI workflow for Windows and macOS, and modifies the flutter integration test action to handle platform-specific configurations and dependencies. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LucasXu0 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a matrix strategy for the OS in the
flutter_integration_test
action to avoid repetition. - The conditional artifact downloads in
flutter_integration_test/action.yml
seem redundant, as the action already knows the runner OS.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
0471f36
to
b6da597
Compare
b6da597
to
ce91b0c
Compare
76203d7
to
3d3b2b3
Compare
1e1930a
to
c29d1d0
Compare
c29d1d0
to
befb8d1
Compare
* fix: unable to accpet 'make it longer' * fix: markdown text robot test
* fix: add error text under text field * chore: update translation
* fix: some link_preview launch review issues * fix: some UI issues * chore: pasting a link will not check whether it is an image * fix: copy link to block not supported well * fix: mention UI issues * feat: support get youtube channel info * chore: update translation * feat: add shadow in appflowy theme * chore: remove AFThemeExtensionV2 * fix: some UI issues
* feat: update i18n and icons * chore: replace appflowy with welcome to appflowy * fix: protenial delete page error * fix: flutter analyze
Feature Preview
PR Checklist
Summary by Sourcery
Extend integration testing to support Windows and macOS platforms in addition to Linux
CI: