chore: enable integration test on windows#7658
Open
LucasXu0 wants to merge 14 commits intoAppFlowy-IO:mainfrom
Open
chore: enable integration test on windows#7658LucasXu0 wants to merge 14 commits intoAppFlowy-IO:mainfrom
LucasXu0 wants to merge 14 commits intoAppFlowy-IO:mainfrom
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request enables integration tests on Windows and macOS platforms, expanding the testing coverage beyond Linux. It introduces new jobs in the CI workflow for Windows and macOS, and modifies the flutter integration test action to handle platform-specific configurations and dependencies. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @LucasXu0 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a matrix strategy for the OS in the
flutter_integration_testaction to avoid repetition. - The conditional artifact downloads in
flutter_integration_test/action.ymlseem redundant, as the action already knows the runner OS.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
0471f36 to
b6da597
Compare
b6da597 to
ce91b0c
Compare
76203d7 to
3d3b2b3
Compare
1e1930a to
c29d1d0
Compare
c29d1d0 to
befb8d1
Compare
* fix: unable to accpet 'make it longer' * fix: markdown text robot test
* fix: add error text under text field * chore: update translation
* fix: some link_preview launch review issues * fix: some UI issues * chore: pasting a link will not check whether it is an image * fix: copy link to block not supported well * fix: mention UI issues * feat: support get youtube channel info * chore: update translation * feat: add shadow in appflowy theme * chore: remove AFThemeExtensionV2 * fix: some UI issues
* feat: update i18n and icons * chore: replace appflowy with welcome to appflowy * fix: protenial delete page error * fix: flutter analyze
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Extend integration testing to support Windows and macOS platforms in addition to Linux
CI: