Skip to content

fix: improve the link menu in read-only mode #8048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

asjqkkkk
Copy link
Collaborator

@asjqkkkk asjqkkkk commented Jun 10, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Centralize read-only handling in link menus by introducing an editable flag, disabling interactive actions and popovers while preserving copy functionality.

Bug Fixes:

  • Disable convert, edit, remove, and more-option popovers when the editor is in read-only mode.
  • Restrict mention and custom link preview menus to only allow the copy action in read-only mode.

Enhancements:

  • Introduce an editable flag in link and mention widgets to toggle interactive behavior based on editor state.
  • Add a getTapCallback utility and transparent hover styling to centrally disable buttons in read-only mode.
  • Propagate the editable state through link embed, hover, and mention components to unify behavior across menus.

Copy link
Contributor

sourcery-ai bot commented Jun 10, 2025

Reviewer's Guide

This PR introduces a unified read‐only mode across all link menus by propagating the editor’s editable state into each menu widget and conditionally disabling or styling interactive elements when not editable.

File-Level Changes

Change Details Files
Propagate editable state into link widgets
  • Add bool get editable => editorState.editable getters
  • Pass editable flag through widget constructors
link_embed_menu.dart
link_hover_menu.dart
mention_link_preview.dart
link_preview_menu.dart
mention_link_block.dart
mention_link_error_preview.dart
Conditionally disable callbacks in read‐only mode
  • Implement getTapCallback to return null when non-editable
  • Replace direct onPressed/onTap assignments with getTapCallback
link_embed_menu.dart
link_hover_menu.dart
Refactor convert & more option buttons in LinkEmbedMenu
  • Extract local button variable in buildConvertButton/buildMoreOptionButton
  • Use button as the popover child when editable
link_embed_menu.dart
Disable non-edit commands and hover styling in preview menus
  • Set hoverColor: Colors.transparent for disabled buttons
  • Conditionally nullify onTap for menu entries except copyLink
link_hover_menu.dart
mention_link_preview.dart
link_preview_menu.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @asjqkkkk - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant