-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix: improve the link menu in read-only mode #8048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's GuideThis PR introduces a unified read‐only mode across all link menus by propagating the editor’s File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @asjqkkkk - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Feature Preview
PR Checklist
Summary by Sourcery
Centralize read-only handling in link menus by introducing an editable flag, disabling interactive actions and popovers while preserving copy functionality.
Bug Fixes:
Enhancements:
editable
flag in link and mention widgets to toggle interactive behavior based on editor state.getTapCallback
utility and transparent hover styling to centrally disable buttons in read-only mode.editable
state through link embed, hover, and mention components to unify behavior across menus.