Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct ignore files regex method for the java frontend #181

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

prabhu
Copy link
Contributor

@prabhu prabhu commented Mar 4, 2025

withDefaultIgnoredFilesRegex doesn't really work with the java frontend due to this line.

ignoredDefaultRegex = Option(JavaSrc2Cpg.DefaultIgnoredFilesRegex),
ignoredFilesRegex = Option(config.ignoredFilesRegex),
ignoredFilesPath = Option(config.ignoredFiles)

Switching to withIgnoredFilesRegex helps fix the issue reported in cdxgen.

@prabhu prabhu added the java label Mar 4, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @prabhu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses an issue where the withDefaultIgnoredFilesRegex method was not working as expected with the Java frontend due to the order in which the ignore file regexes were being applied. The change replaces withDefaultIgnoredFilesRegex with withIgnoredFilesRegex and updates the regex to correctly ignore target and build directories.

Highlights

  • Bug Fix: Fixes an issue where default ignored files regex was not working correctly for the Java frontend.
  • Regex Update: Updates the ignored files regex to correctly ignore target and build directories.
  • Method Replacement: Replaces withDefaultIgnoredFilesRegex with withIgnoredFilesRegex to ensure correct application of ignore rules.

Changelog

  • src/main/scala/io/appthreat/atom/Atom.scala
    • Replaced withDefaultIgnoredFilesRegex with withIgnoredFilesRegex.
    • Updated the ignored files regex to .*(target|build)/(generated|intermediates|outputs|tmp).*.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Did you know?

The .scala file extension stands for Scalable Language.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@prabhu prabhu merged commit 7adcad7 into main Mar 5, 2025
21 checks passed
@prabhu prabhu deleted the fix/ignore-generated-target branch March 5, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant