Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allows players to reverse the function of '#' and '$' in search #8291

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LittleCircleOO
Copy link

Upon investigation, there is a difference in how # and $ are handled by different mods:

Prefix # $
JEI tag tooltip
REI tooltip tag
EMI tag tooltip
RS tooltip tag

So a client-side setting is provided to allow players to reverse their functionality, which also automatically assigns defaults based on the item lists mod on first load.

@Mari023
Copy link
Contributor

Mari023 commented Jan 2, 2025

Don't some recipe viewers also have the ability to use any arbitrary symbol for those functions? (I think I have seen this in either REI or EMI, possibly both) It might make sense to have an option to get those symbols from the recipe viewer

@LittleCircleOO
Copy link
Author

Don't some recipe viewers also have the ability to use any arbitrary symbol for those functions? (I think I have seen this in either REI or EMI, possibly both) It might make sense to have an option to get those symbols from the recipe viewer

Unfortunately, neither of these recipe viewer mods has been given a configuration option, and currently they only have a ‘search with or without prefix’ option, and custom prefixes are not yet supported.
Related issues:
emilyploszaj/emi#767
shedaniel/RoughlyEnoughItems#1652

This pull request will be marked as a draft for now and will be re-enabled when the recipe viewer supports this feature.

@LittleCircleOO LittleCircleOO marked this pull request as draft January 13, 2025 05:51
@Mari023
Copy link
Contributor

Mari023 commented Jan 13, 2025

imo automatically switching to adjust to the default of the recipe viewers and having the option to switch it in ae2 already is a big improvement, I don't think we should block this PR on other recipe viewers getting the option to adjust this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants