Core: Make csv options output ignore hidden options #4539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
ScipioWright
added
the
is: bug/fix
|
Somewhat unrelated, but why do the invisible options have display names? |
|
Would it make sense to read the spoiler log flag for outputting to csv_output? |
Berserker66
reviewed
Jan 22, 2025
Options.py
Outdated
| @@ -1582,7 +1582,7 @@ def dump_player_options(multiworld: MultiWorld) -> None: | |||
| } | |||
| output.append(player_output) | |||
| for option_key, option in world.options_dataclass.type_hints.items(): | |||
| if issubclass(Removed, option): | |||
| if issubclass(Removed, option) or option.visibility == Visibility.none: | |||
There was a problem hiding this comment.
Suggested change
| if issubclass(Removed, option) or option.visibility == Visibility.none: | |
| if Visibility.spoiler not in option.visibility: |
There was a problem hiding this comment.
I think you'd still want non-spoiler options. Like if a world displayed an option in its own way and set it to not appear in the spoiler, it could still impact logic and be valuable to the csv output
Co-authored-by: Aaron Wagener <[email protected]>
qwint
approved these changes
Jan 24, 2025
alwaysintreble
approved these changes
Jan 29, 2025
alwaysintreble
added
waiting-on: core-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Generate with
--csv_outputwould also output options set toVisibility.none, this causes an issue in for example Timespinner's backwards compatibility options, causing their values to display rather then new options as they share the same display nameHow was this tested?
locally generating with
--csv_outputand with and without this change