Webhost: Update random option wording on webhost #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: webhost
|
Very much in favor of this change. Wording looks good to me. |
Jouramie
approved these changes
Jan 26, 2025
| @@ -213,7 +213,7 @@ | |||
| {% endmacro %} | |||
|
|
|||
| {% macro RandomizeButton(option_name, option) %} | |||
| <div class="randomize-button" data-tooltip="Toggle randomization for this option!"> | |||
| <div class="randomize-button" data-tooltip="Pick a random choice for this option."> | |||
There was a problem hiding this comment.
For range option, I think it does not really make sense to pick a "choice". One could argue that all possible values are a choice, but I think it would make more sense (to my non-native English speaker mind) to call it directly a value, as that would also fit choice options.
Suggested change
| <div class="randomize-button" data-tooltip="Pick a random choice for this option."> | |
| <div class="randomize-button" data-tooltip="Pick a random value for this option."> |
There was a problem hiding this comment.
I personally think using "value" might make it more confusing to some vs choice? But it's sorta vibes based, so idk. If someone else chimes in too and says value better I'll probably change it
Exempt-Medic
added
the
is: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This is for the tooltip on the little die button next to the options for a game on webhost.
Toggle randomization for this option!kind of makes it sound like if you don't click this, nothing about it will be randomized.Changing the wording so it is a little clearer.
How was this tested?
Reading