Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUNIC: Move stuff around and stop using the old rules file #4569

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ScipioWright
Copy link
Collaborator

@ScipioWright ScipioWright commented Jan 29, 2025

What is this fixing or adding?

This PR does 3 things:

  • Remove the old rules file and replace it with er_rules. Most options already use er_rules, we just kept the old ones if you didn't have ER, ladder shuffle, grass, combat logic, etc. on.
    • er_rules renamed to rules
    • er_data renamed to region_data
    • some helper functions moved to a new helper_functions file
  • Move the imports around. Just some reorganizing, none of them changed (except ones that got moved to that new file)
  • Remove a test that stops being useful due to the events that the ER rules had (since collect by name collects events)

The diff looks awful but please trust me that I did not sneak anything weird in here. It's a very very simple PR.

Things to do in a follow up PR:

  • Consider removing the LocationData tuples and use a simple dict instead since it might be simpler to just do the location groups separately down below, since most locations don't get that location group item filled in

How was this tested?

Test gens, unit tests.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jan 29, 2025
@ScipioWright ScipioWright added the is: refactor/cleanup Improvements to code/output readability or organizization. label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant