TUNIC: Move stuff around and stop using the old rules file #4569
+8,383
−10,241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This PR does 3 things:
rules
file and replace it wither_rules
. Most options already useer_rules
, we just kept the old ones if you didn't have ER, ladder shuffle, grass, combat logic, etc. on.er_rules
renamed torules
er_data
renamed toregion_data
helper_functions
fileThe diff looks awful but please trust me that I did not sneak anything weird in here. It's a very very simple PR.
Things to do in a follow up PR:
How was this tested?
Test gens, unit tests.