Stardew Valley: Add walnutsanity prefix to locations #4934
+231
−206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jouramie
force-pushed
the
StardewValley/add-walnutsanity-prefix-to-locations
branch
from
32fcbaa to
28a9310
Compare
agilbert1412
added
is: refactor/cleanup
agilbert1412
approved these changes
May 31, 2025
Emerassi
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
I haven't reviewed any unit tests prior to this so take my approval with a grain of salt. That said they look very understandable. I double checked that all the .assertIn converted to expected_walnut_locations and the .assertNotIn converted to unexpected_walnut_locations.
qwint
added
waiting-on: core-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
We often have players in the Stardew channel wondering what is [insert random walnut location]. This adds a prefix to all the walnutsanity locations, so it's easier for players to understand which checks are walnuts.
I also took the time to convert the Walnutsanity tests to the base class.
The mod supports the prefix since last year. We initially aimed to only change the location name with the 7xx release, but since it's supported by the mod, we can do it now!
How was this tested?
Yes
If this makes graphical changes, please attach screenshots.
N/A