Skip to content

Stardew Valley: Extract fillers creation in its own file and update item classification post fill #5044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Jouramie
Copy link
Contributor

What is this fixing or adding?

This PR does two things.

  • First, it refactors the fillers creation to be more readable and moves it to its own file, but exposes it through the items module.
  • Second, it allows changing items classification once the fill is completed. This allows the prog balancing to do a better job since it will now know that some of the fillers are in fact progression. Based on this conversation: https://discord.com/channels/731205301247803413/1214608557077700720/1343381004357734492

How was this tested?

Run a couple of generation and make sure similar fillers are generated

If this makes graphical changes, please attach screenshots.

N/A

Jouramie added 3 commits May 17, 2025 14:09
- Change useful progression items into progression skip balancing after fill
- Split fillers creating into their own file
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 24, 2025
@agilbert1412 agilbert1412 added the is: enhancement Issues requesting new features or pull requests implementing new features. label May 24, 2025
Copy link
Collaborator

@agilbert1412 agilbert1412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are nitpicks, approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants