Skip to content

WebHost: Fix adding weighted text options #5116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WebHost: Fix adding weighted text options #5116

wants to merge 2 commits into from
+24 −10

Conversation

josephwhite
Copy link
Contributor

What is this fixing or adding?

Fixes the add button for TextChoice and FreeText options on Weighted Options pages.
To resolve #3800 #4174.

How was this tested?

  • Exported weighted YAMLs with custom values for Pokemon RB's Trainer Name, Pokemon Emerald's Easter Egg, and TUNIC's Entrance Rando.
  • Generated a seed using the above YAMLs.
  • Quick check on one of the regular (numeric) range options to be sure that didn't break.

@github-actions github-actions bot added the affects: webhost Issues/PRs that touch webhost and may need additional validation. label Jun 15, 2025
@josephwhite josephwhite marked this pull request as ready for review June 21, 2025 02:22
@Exempt-Medic Exempt-Medic added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: WebHost: TextChoice and FreeText Add buttons on advanced option pages do not work
2 participants
@josephwhite @Exempt-Medic