Wargroove communication thread fix #5125
Merged
+67
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thread and keep the thread alive.
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
the
is: bug/fix
| ctx.finished_game = True | ||
| await asyncio.sleep(0.1) | ||
|
|
||
| except Exception as err: |
There was a problem hiding this comment.
Is this meant to just catch all possible exceptions and not any particular types that you expect to see?
There was a problem hiding this comment.
Unfortunately I don't know what exceptions cause the thread to crash. I don't want it to stop regardless.
Exempt-Medic
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This fixes the crashes found in the communication thread for the Wargroove 1 client. It also keeps the communication thread alive.
How was this tested?
I hard coded an exception and it was caught. The thread was verified to still be running. I started the client normally and it functioned as intended.
If this makes graphical changes, please attach screenshots.