Archipelago: add MC/DC unit tests for process_single_entrance #5127
+169
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
|
at bar minimum these should be using unittest classes per https://github.com/ArchipelagoMW/Archipelago/blob/main/docs/tests.md and if this is a lingo specific test it should be added to the lingo world and with approval by the lingo codeowner defined in https://github.com/ArchipelagoMW/Archipelago/blob/main/docs/CODEOWNERS |
ScipioWright
added
is: enhancement
NewSoupVi
added
waiting-on: author
|
Yeah this should be a Lingo unit test inside worlds/Lingo/test (and should use Lingo's testbase if applicable) Hopefully it's easy to convert, this seems like a good thing :) |
|
Also @hatkirby are you conceptually on board? Before they do all the work of converting it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This pull request adds a complete set of MC/DC (Modified Condition/Decision Coverage) unit tests for the process_single_entrance method located in worlds/lingo/utils/pickle_static_data.py.
These tests improve the test coverage of this method, covering all independent conditions and decision paths.
How was this tested?
All new tests were implemented using pytest.
Execution result: 19 tests passed successfully with no failures.
Warnings shown during execution are unrelated to the method and come from external dependencies.
If this makes graphical changes, please attach screenshots.
N/A (No graphical changes)