Core: Add a search_item client command #5128
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this is something that I whipped up and tested. If there is a different name or behavior or method of implementation of this command that is desired, please let me know, so then I can revise it.
What is this?
This code adds a new command for clients which can query items. The allows users to search item names that exist in the current slot's world.
Why is this needed?
The Pitch
This is needed because there are too many instances where I am trying to hint for items that I do not know the exact name for. Plus, I get questions for my own apworld occasionally about what is the name of [item]. This would just make it easier to find items to hint.
This allows a user to find what items exist in the current world without second guessing themselves.
How was this tested?
Tested various queries. Tested querying items from current world and other worlds in the multiworld. Made sure that only current world items are queried.
What if I do not like this implementation?
This can be adjusted to behave in different ways depending on preference. I just implemented it in a way that at least I think is reasonable behavior, but I am not everyone.
Visual Example