-
Notifications
You must be signed in to change notification settings - Fork 1k
[CORE + Many games] - Clients and Adjusters cleanup #5148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ReverM
wants to merge
47
commits into
ArchipelagoMW:main
Choose a base branch
from
ReverM:client-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+916
−919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added non-AP World specific information
Fixed broken link
Some minor touchups
Draft for version with picture
Small word change
Minor updates for conciseness, mostly
Sync contributing so I dont have to deal with it anymore
Cleanup
qwint
reviewed
Jun 30, 2025
Change relative import to be better Co-authored-by: qwint <[email protected]>
Fixed styling issues
Still a lil bit more work needed. Apologies |
By a bit more work I meant two lines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects: core
Issues/PRs that touch core and may need additional validation.
affects: webhost
Issues/PRs that touch webhost and may need additional validation.
is: refactor/cleanup
Improvements to code/output readability or organizization.
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Removing all game client and adjuster script from root, and put them in their respective game directories
Edited worlds.LauncherComponents by removing game specific launcher component from the "components" list
Edited various root files with reference to clients and adjuster to take into consideration the refactor
Moved all client and adjusters to their respective game directories
Edited affected game's
_init_.py
to take into consideration the refactorHow was this tested?
Every client and adjuster was tested through the launcher
An installation was tested and it succesfully compiled the ArchipelagoLauncher.exe, while not compiling the other exes
If this makes graphical changes, please attach screenshots.