Skip to content

[CORE + Many games] - Clients and Adjusters cleanup #5148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

ReverM
Copy link
Contributor

@ReverM ReverM commented Jun 30, 2025

What is this fixing or adding?

Removing all game client and adjuster script from root, and put them in their respective game directories

Edited worlds.LauncherComponents by removing game specific launcher component from the "components" list
Edited various root files with reference to clients and adjuster to take into consideration the refactor
Moved all client and adjusters to their respective game directories
Edited affected game's _init_.py to take into consideration the refactor

How was this tested?

Every client and adjuster was tested through the launcher
An installation was tested and it succesfully compiled the ArchipelagoLauncher.exe, while not compiling the other exes

If this makes graphical changes, please attach screenshots.

ReverM and others added 30 commits October 4, 2023 17:31
Added non-AP World specific information
Fixed broken link
Draft for version with picture
Small word change
Minor updates for conciseness, mostly
Sync contributing so I dont have to deal with it anymore
@ReverM ReverM requested a review from Berserker66 as a code owner June 30, 2025 00:52
@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 30, 2025
@ReverM ReverM requested a review from qwint June 30, 2025 02:36
@ReverM ReverM marked this pull request as draft June 30, 2025 02:41
@ReverM
Copy link
Contributor Author

ReverM commented Jun 30, 2025

Still a lil bit more work needed. Apologies

@ReverM
Copy link
Contributor Author

ReverM commented Jun 30, 2025

Still a lil bit more work needed. Apologies

By a bit more work I meant two lines

@ReverM ReverM marked this pull request as ready for review June 30, 2025 14:13
@ScipioWright ScipioWright added the is: refactor/cleanup Improvements to code/output readability or organizization. label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. affects: webhost Issues/PRs that touch webhost and may need additional validation. is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants