Stardew Valley: Fixed luck level requirements for slot machines #5160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # worlds/stardew_valley/data/craftable_data.py
github-actions
bot
added
the
waiting-on: peer-review
agilbert1412
added
the
is: bug/fix
|
Can confirm that it's not at level 4. Logic looks right now. |
ProfBytes
approved these changes
Jul 3, 2025
agilbert1412
added
waiting-on: core-review
Jouramie
approved these changes
Jul 3, 2025
NewSoupVi
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
It was discovered today that the slot machine level requirements are 2-4-6-8, not 2-4-4-4. I suspect it was a bad copy paste job originally.
The mod data can be found here: https://github.com/Pet-Slime/StardewValley/blob/master/LuckSkillCode/ContentPatcher/%5BCP%5D%20LuckSkill/Data/CraftingData.json
How was this tested?
Not much. It still passes tests, but I didn't make a new one, as this is an arbitrary value and the test would have to be just as arbitrary