Use Mesa from Mesa-Upstream Git via git-subtree #340
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the usage into the one place that it's used.
…ved the IN_DRI_DRIVER cruft. This was suggested by George Fufutos.
determines the bits (either 32 or 64) for libraries without the lib prefix. progs/egl/Makefile passes CFLAGS on the link commands so that things like '-m32' get propagated.
…o call the Delete methods after
context destroy. Fixes memory leak.
attributes in display lists. If a driver doesn't add entry points for GL_NV_vertex_program, it will explode. This patch adds GL_NV_vertex_program to the list of default extensions whose entry points are added by driInitExtensions. Thanks go to Roland Scheidegger for tracking the problem down and suggesting the fix.
…ader to the driver. The loader now takes care of this for the driver. Remove _glapi_DispatchTSD and give _glapi_Dispatch its semantic (i.e., having a NULL value means that the application is multithreaded and _glapi_get_dispatch must be called). Gut all of the dispatch override code. This removes _glapi_RealDispatch, _glapi_tls_RealDispatch, _glapi_begin_dispatch_override, _glapi_end_dispatch_override, and _glapi_get_override_dispatch. Remove _glapi_get_proc_address, _glapi_get_proc_name, _glapi_get_version, and _glapi_check_table from the loader / driver interface. Reviewed by: Brian Paul
proper DRM_CAS_RESULT to declare the variable used to store the result of DRM_CAS. Second, only use the "real" versions of LOCK_HARDWARE and UNLOCK_HARDWARE on SPARC. That's the only platform where the hardware can really exist.
available, and on libGL setups libEGL and libEGLdri aren't available.
…. The big, ugly, error prone switch-statement is replaced with a compact table. I also added numerous comments, including a comment explaining how the format parameter is validated. Explicitly pass GL_FLOAT as the type in the cases where that is the only possible value (e.g., everywhere except the call to glColorPointer). Validate that stride is >= 0. Tested with all modes (including the two error modes) of progs/tests/interleave.c. Bug: #5001, #5058 Reviewed by: Brian Paul
Member
|
@sunweaver: I have been not putting too much attention into NX development lately, so, that may have been already discussed somewhere else, but I am missing the high level plan for getting OpenGL to work over NX. |
Member
Author
|
Hi Salva,
On Mon Feb 20 15:55:05 2017 GMT+0100, Salvador Fandiño wrote:
@sunweaver: I have been not putting too much attention into NX development lately, so, that may have been already discussed somewhere else, but I am missing the high level plan for getting OpenGL to work over NX.
I see a good chance of getting glx 1.4 to work base on this PR. My question is about the best approach for pulling in a Git repo into another's subfolder.
Mike
…--
Sent from my Fairphone (running Sailfish OS)...
|
Member
|
I think Salva means a plan for accellerated OpenGL...
Vom Smartphone gesendet.
----- Ursprüngliche Nachricht -----
Von: "Mike Gabriel" <[email protected]>
Gesendet: 20.02.2017 19:20
An: "ArcticaProject/nx-libs" <[email protected]>
Cc: "Ulrich Sibiller" <[email protected]>; "Review requested" <[email protected]>
Betreff: Re: [ArcticaProject/nx-libs] Use Mesa from Mesa-Upstream Git viagit-subtree (#340)
Hi Salva,
On Mon Feb 20 15:55:05 2017 GMT+0100, Salvador Fandiño wrote:
@sunweaver: I have been not putting too much attention into NX development lately, so, that may have been already discussed somewhere else, but I am missing the high level plan for getting OpenGL to work over NX.
I see a good chance of getting glx 1.4 to work base on this PR. My question is about the best approach for pulling in a Git repo into another's subfolder.
Mike
…--
Sent from my Fairphone (running Sailfish OS)...
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
Ah, ok, I though this PR was already part of that plan! |
…t subtree of Mesa_6.4.1 instead.
… pulled in via git subtree.
…ion when creating release tarballs.
sunweaver
force-pushed
the
pr/use-Mesa-from-Git
branch
from
3f05402 to
5a0d5d6
Compare
Member
|
No time for a review now, but: why does this pr remove 27000 lines but add 824000 lines? Shouldn't this be more or less the same amount? |
Member
Author
|
On Do 02 Mär 2017 15:09:36 CET, Ulrich Sibiller wrote:
No time for a review now, but: why does this pr remove 27000 lines
but add 824000 lines? Shouldn't this be more or less the same amount?
The nx-libs bundle folder nx-X11/extras/Mesa contained only a subset
of the Mesa library, whereas the Git subtree contains all Mesa files
of the 6.4.1 release.
I am still unsure about the subtree approach here, but I heard many
people whine about the git submodule feature and sigh with relief when
git subtree arrived. So...
--
DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31
mail: [email protected], http://das-netzwerkteam.de
|
Closed
Member
Author
|
Superseded by just merged PR #467. Thus, closing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in a massive commit history from Mesa upstream. The mechanism used is "git-subtree". It may be discussed if Git submodule is more appropriate, but I sense that git-subtree is the more state-of-the-art approach for pulling in Vcs-based 3rd-party projects.
@Ionic: @vatral: @salva: @uli42: @mikedep333: Request for comments!!!