Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various backports for Xserver/mi/miexpose (esp. miPaintWindow rewrite) #424

Open
wants to merge 5 commits into
base: 3.6.x
Choose a base branch
from
Open

Various backports for Xserver/mi/miexpose (esp. miPaintWindow rewrite) #424

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71dce0e
Xserver/mi/miexpose.c: Rewrite miPaintWindow to draw to window pixmap.
Apr 11, 2017
2e54c23
mi: Move pScreen->SendGraphicsExpose up to dix
sunweaver Apr 11, 2017
0090b31
Xserver/mi/miexpose.c: Fix the tile offset in miPaintWindow for Paren…
Apr 11, 2017
fca6b5b
Xserver/mi/miexpose.c: Fix border tile origin when background is Pare…
peterh Apr 11, 2017
2d23e8a
misc nx-X11/programs/Xserver/{fb,mi}/: backport 2e76958d304a3c4080d62…
Sep 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nx-X11/programs/Xserver/mi/miexpose.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,8 +610,8 @@ miPaintWindow(WindowPtr pWin, RegionPtr prgn, int what)
draw_x_off = drawable->x;
draw_y_off = drawable->y;

tile_x_off = 0;
tile_y_off = 0;
tile_x_off = pWin->drawable.x - draw_x_off;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backport might be meant well, but won't actually fix anything. With the current code, the behavior will at best be unchanged (since the new expressions should evaluate to zero anyway) and in the worst case break completely due to underflows.

For this to actually work correctly, we'll need a partial or full backport of e4d11e58ce349dfe6af2f73ff341317f9b39684c first - but that one is HUGE!

tile_y_off = pWin->drawable.y - draw_y_off;
fill = pWin->background;
switch (pWin->backgroundState) {
case None:
Expand Down