IMPROVEMENT: simplify internationalization

Author: amilcarlucas

MethodicConfigurator/__init__.py

@@ -1 +1,15 @@
-"""ArduPilot Methodic Configurator GUI application"""  # pylint: skip-file
+#!/usr/bin/env python3
+
+"""
+This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+
+SPDX-FileCopyrightText: 2024 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
+
+SPDX-License-Identifier: GPL-3.0-or-later
+"""
+# pylint: skip-file
+
+from MethodicConfigurator.internationalization import load_translation
+
+
+_ = load_translation()

MethodicConfigurator/ardupilot_methodic_configurator.py

@@ -27,7 +27,7 @@
 from MethodicConfigurator.frontend_tkinter_directory_selection import VehicleDirectorySelectionWindow
 from MethodicConfigurator.frontend_tkinter_flightcontroller_info import FlightControllerInfoWindow
 from MethodicConfigurator.frontend_tkinter_parameter_editor import ParameterEditorWindow
-from MethodicConfigurator.internationalization import _, load_translation
+from MethodicConfigurator import _
 from MethodicConfigurator.version import VERSION
 
 
@@ -113,10 +113,6 @@ def component_editor(args, flight_controller, vehicle_type, local_filesystem, ve
 
 
 def main():
-    # modify the global _() function
-    global _  # pylint: disable=global-statement
-
-    _ = load_translation()  # done as soon as possible so that the correct language is used
     args = argument_parser()
 
     logging_basicConfig(level=logging_getLevelName(args.loglevel), format="%(asctime)s - %(levelname)s - %(message)s")

MethodicConfigurator/argparse_check_range.py

@@ -13,7 +13,7 @@
 from argparse import Action, ArgumentError
 from operator import ge, gt, le, lt
 
-from MethodicConfigurator.internationalization import _
+from MethodicConfigurator import _
 
 
 class CheckRange(Action):

MethodicConfigurator/backend_filesystem.py

@@ -40,7 +40,7 @@
 from MethodicConfigurator.backend_filesystem_configuration_steps import ConfigurationSteps
 from MethodicConfigurator.backend_filesystem_program_settings import ProgramSettings
 from MethodicConfigurator.backend_filesystem_vehicle_components import VehicleComponents
-from MethodicConfigurator.internationalization import _
+from MethodicConfigurator import _
 
 TOOLTIP_MAX_LENGTH = 105
 

MethodicConfigurator/backend_filesystem_configuration_steps.py

@@ -20,7 +20,7 @@
 from typing import Tuple
 
 from MethodicConfigurator.annotate_params import Par
-from MethodicConfigurator.internationalization import _
+from MethodicConfigurator import _
 
 
 class ConfigurationSteps:

MethodicConfigurator/backend_filesystem_program_settings.py

@@ -23,7 +23,7 @@
 
 from platformdirs import site_config_dir, user_config_dir
 
-from MethodicConfigurator.internationalization import _
+from MethodicConfigurator import _
 
 
 class ProgramSettings:

MethodicConfigurator/backend_filesystem_vehicle_components.py

@@ -23,7 +23,7 @@
 from re import match as re_match
 
 from MethodicConfigurator.backend_filesystem_program_settings import ProgramSettings
-from MethodicConfigurator.internationalization import _
+from MethodicConfigurator import _
 from MethodicConfigurator.middleware_template_overview import TemplateOverview
 
 

MethodicConfigurator/backend_flightcontroller.py

@@ -27,7 +27,7 @@
 from MethodicConfigurator.argparse_check_range import CheckRange
 from MethodicConfigurator.backend_flightcontroller_info import BackendFlightcontrollerInfo
 from MethodicConfigurator.backend_mavftp import MAVFTP
-from MethodicConfigurator.internationalization import _
+from MethodicConfigurator import _
 
 # adding all this allows pyinstaller to build a working windows executable
 # note that using --hidden-import does not work for these modules

MethodicConfigurator/common_arguments.py

@@ -8,7 +8,8 @@
 SPDX-License-Identifier: GPL-3.0-or-later
 """
 
-from MethodicConfigurator.internationalization import LANGUAGE_CHOICES, _
+from MethodicConfigurator import _
+from MethodicConfigurator.internationalization import LANGUAGE_CHOICES
 from MethodicConfigurator.version import VERSION
 
 
@@ -26,7 +27,7 @@ def add_common_arguments_and_parse(parser):
     parser.add_argument(
         "--language",
         type=str,
-        default="en",
+        default=LANGUAGE_CHOICES[0],
         choices=LANGUAGE_CHOICES,
         help=_("User interface language (default is %(default)s)."),
     )

MethodicConfigurator/frontend_tkinter_base.py

@@ -25,7 +25,7 @@
 
 from MethodicConfigurator.backend_filesystem import LocalFilesystem
 from MethodicConfigurator.backend_filesystem_program_settings import ProgramSettings
-from MethodicConfigurator.internationalization import _
+from MethodicConfigurator import _
 
 
 def show_error_message(title: str, message: str):