Skip to content

Conversation

@Requieem
Copy link

The Info text bullet points were often getting pushed down in the column and it was difficult to control its distance from the "bars" showing the validation steps using height only, as restricting the height would cause the bullet points to overflow. With these changes, elements of the validator are now aligned to the start of the column and a new SizedBox spacer has been added to control spacing between the two validator visual features (the bars / the text)

The Info text bullet points were often getting pushed down in the column and it was difficult to control its distance from the "bars" showing the validation steps using height only, as restricting the height would cause the bullet points to overflow. With these changes, elements of the validator are now aligned to the start of the column and a new SizedBox spacer has been added to control spacing between the two validator visual features (the bars / the text)
@Requieem
Copy link
Author

If you'd like, I could also add another before-spacer the same way but I'll wait for you guys to review this one since I do not have a use case for that yet. Thanks for this package btw!

@ArefMozafari
Copy link
Owner

Sorry for this long delay.
Thanks for the contribution .
Please update readme and example app also.

@Requieem
Copy link
Author

Will do! Thanks for the response.

@ArefMozafari
Copy link
Owner

Hello again, I'm still waiting for the changes.

Could you please also rename the newly added property spaceBetween to something more descriptive? Like barsAndTextsSpace, sectionsSpace and etc.

Thank you for your time and effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants