Skip to content

Conversation

@ejsears
Copy link
Collaborator

@ejsears ejsears commented Nov 2, 2025

Major Changes in this PR

This pull request refactors the configuration of advanced settings for the poop macro by moving related variables from the macro definition file (Poop.cfg) into the central configuration file (AFC_Macro_Vars.cfg). The macro now retrieves these settings from the global variable store, improving maintainability and centralizing control of macro parameters.

Configuration refactoring and centralization:

  • Moved advanced poop macro settings (max_iteration_length, iteration_z_raise, iteration_z_change, max_iterations_per_blob, pressure_release_time, purge_z) from config/macros/Poop.cfg to config/AFC_Macro_Vars.cfg for centralized management. [1] [2]

Macro logic update:

  • Updated the AFC_POOP macro in config/macros/Poop.cfg to retrieve the advanced settings from the global variable store, ensuring the macro uses the centralized configuration.

Notes to Code Reviewers

Closes #558

How the changes in this PR are tested

Updated AFC_Macro_Vars and poop.cfg and verified operation still works.

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Documentation updated in AT-Documentation repository
  • Sent notification to software-design/software-discussions channel (as appropriate) requesting review
  • If this PR address a GitHub issue, the issue number is referenced in the PR description

NOTE: GitHub Copilot may be used for automated code reviews, however as it is an automated system, it's suggestions
may not be correct. Please do not rely on it to catch all issues. Please review any suggestions it makes and use your
own judgement to determine if they are correct.

@ejsears ejsears requested a review from jimmyjon711 November 2, 2025 20:35
@ejsears ejsears linked an issue Nov 2, 2025 that may be closed by this pull request
@ejsears
Copy link
Collaborator Author

ejsears commented Nov 2, 2025

@jimmyjon711 I have no clue what the description would be for those variables.

@ejsears ejsears requested a review from jimmyjon711 November 8, 2025 12:30
Copy link
Collaborator

@jimmyjon711 jimmyjon711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ejsears ejsears merged commit f1ca021 into ArmoredTurtle:DEV Nov 9, 2025
1 check passed
@ejsears ejsears deleted the issue_558 branch November 9, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Expose all poop variables to the poop cfg section

2 participants