Feat: Add advanced settings for AFC_POOP macro configuration #564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes in this PR
This pull request refactors the configuration of advanced settings for the poop macro by moving related variables from the macro definition file (
Poop.cfg) into the central configuration file (AFC_Macro_Vars.cfg). The macro now retrieves these settings from the global variable store, improving maintainability and centralizing control of macro parameters.Configuration refactoring and centralization:
max_iteration_length,iteration_z_raise,iteration_z_change,max_iterations_per_blob,pressure_release_time,purge_z) fromconfig/macros/Poop.cfgtoconfig/AFC_Macro_Vars.cfgfor centralized management. [1] [2]Macro logic update:
AFC_POOPmacro inconfig/macros/Poop.cfgto retrieve the advanced settings from the global variable store, ensuring the macro uses the centralized configuration.Notes to Code Reviewers
Closes #558
How the changes in this PR are tested
Updated AFC_Macro_Vars and poop.cfg and verified operation still works.
PR Checklist: (Checked-off items are either done or do not apply to this PR)
NOTE: GitHub Copilot may be used for automated code reviews, however as it is an automated system, it's suggestions
may not be correct. Please do not rely on it to catch all issues. Please review any suggestions it makes and use your
own judgement to determine if they are correct.