Skip to content

Conversation

@ejsears
Copy link
Collaborator

@ejsears ejsears commented Nov 3, 2025

Major Changes in this PR

This pull request addresses a calibration issue in the AFC system and improves user feedback when filament fails to reach the hub sensor during calibration. The most important changes clarify the error message shown to users and document this fix in the changelog.

User feedback improvements

  • Enhanced the failure message in calibrate_lane within extras/AFC_BoxTurtle.py to provide clearer guidance if the filament fails to reach the hub sensor during AFC calibration, including troubleshooting steps and suggestions for adjusting dist_hub.

Documentation updates

  • Added a fix entry to CHANGELOG.md describing the clarified message for AFC calibration failures related to the filament not reaching the hub sensor.

Notes to Code Reviewers

Closes #559

How the changes in this PR are tested

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Documentation updated in AT-Documentation repository
  • Sent notification to software-design/software-discussions channel (as appropriate) requesting review
  • If this PR address a GitHub issue, the issue number is referenced in the PR description

NOTE: GitHub Copilot may be used for automated code reviews, however as it is an automated system, it's suggestions
may not be correct. Please do not rely on it to catch all issues. Please review any suggestions it makes and use your
own judgement to determine if they are correct.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the error message displayed when AFC calibration fails during the "retract to extruder" phase. The enhanced message provides more detailed troubleshooting guidance for users.

  • Updated error message for calibration failure during the "retract to extruder" checkpoint to include specific troubleshooting steps and configuration guidance
  • Added changelog entry documenting this user-facing improvement

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
extras/AFC_BoxTurtle.py Enhanced error message for calibration failure during "retract to extruder" phase with detailed troubleshooting instructions
CHANGELOG.md Added changelog entry for the improved calibration error message

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ejsears ejsears requested a review from jimmyjon711 November 8, 2025 12:26
Copy link
Collaborator

@jimmyjon711 jimmyjon711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jimmyjon711 jimmyjon711 merged commit b478988 into ArmoredTurtle:main Nov 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Error message when calibration errors out for exceeding the retract distance limit is unclear.

2 participants