Skip to content

Conversation

@ejsears
Copy link
Collaborator

@ejsears ejsears commented Nov 9, 2025

Major Changes in this PR

Notes to Code Reviewers

How the changes in this PR are tested

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Documentation updated in AT-Documentation repository
  • Sent notification to software-design/software-discussions channel (as appropriate) requesting review
  • If this PR address a GitHub issue, the issue number is referenced in the PR description

NOTE: GitHub Copilot may be used for automated code reviews, however as it is an automated system, it's suggestions
may not be correct. Please do not rely on it to catch all issues. Please review any suggestions it makes and use your
own judgement to determine if they are correct.

@ejsears ejsears requested a review from Copilot November 9, 2025 15:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for the OpenAMS (Open Automatic Material System) hardware to the AFC (Armored Filament Changer) installation script. OpenAMS is a multi-material management system similar to BoxTurtle and QuattroBox.

Key Changes:

  • Added OpenAMS as a new installation type option alongside BoxTurtle, NightOwl, HTLF, and QuattroBox
  • Created configuration templates for OpenAMS hardware (AFC_Oams.cfg and AFC_AMS_1.cfg)
  • Updated installation menus and flows to support OpenAMS-specific settings and visual branding
  • Modified utility functions to handle OpenAMS configuration copying and unit installation

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 15 comments.

Show a summary per file
File Description
templates/AFC_Oams.cfg New configuration template for OpenAMS hardware with MCU settings, OAMS parameters, FPS configuration, and temperature sensor setup
templates/AFC_AMS_1.cfg New configuration template defining AFC lanes and hubs for a single AMS unit with 4 lanes
include/utils.sh Added copy_openams_config function and test mode check for conditional Klipper restart
include/unit_functions.sh Extended unit naming validation and installation logic to support OpenAMS units
include/menus/install_menu.sh Updated installation menu with OpenAMS ASCII art, conditional prompts for FPS board vs TN/TN2 buffer, and formatting improvements
include/menus/additional_system_menu.sh Added OpenAMS support to additional system menu with ASCII art and unit naming
include/install_functions.sh Added OpenAMS-specific file copying logic and hardware configuration with AMS_extruder switch pin setting
include/constants.sh Added "OpenAMS" to the list of available installation options

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ejsears ejsears marked this pull request as ready for review November 9, 2025 15:54
@ejsears ejsears requested a review from jimmyjon711 November 9, 2025 15:54
@jimmyjon711 jimmyjon711 merged commit b4ab850 into ArmoredTurtle:multi_extruder Nov 9, 2025
1 check passed
lindnjoe added a commit to lindnjoe/AFC-Klipper-Add-On that referenced this pull request Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants