Skip to content

Conversation

@jimmyjon711
Copy link
Collaborator

@jimmyjon711 jimmyjon711 commented Nov 14, 2025

Major Changes in this PR

  • Changed order of eject when performing infinite spool change over, new order is tool unload -> eject spool -> load rollover lane.

Resolves: #549

Notes to Code Reviewers

How the changes in this PR are tested

  • Tested and verified that new sequence works

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Documentation updated in AT-Documentation repository
  • Sent notification to software-design/software-discussions channel (as appropriate) requesting review
  • If this PR address a GitHub issue, the issue number is referenced in the PR description

NOTE: GitHub Copilot may be used for automated code reviews, however as it is an automated system, it's suggestions
may not be correct. Please do not rely on it to catch all issues. Please review any suggestions it makes and use your
own judgement to determine if they are correct.

@jimmyjon711 jimmyjon711 requested a review from ejsears November 14, 2025 17:00
@jimmyjon711 jimmyjon711 linked an issue Nov 14, 2025 that may be closed by this pull request
@ejsears ejsears requested a review from Copilot November 14, 2025 18:39
Copilot finished reviewing on behalf of ejsears November 14, 2025 18:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the infinite spool changeover sequence to reduce nozzle oozing during filament changes. The new sequence unloads the tool, ejects the empty spool, and then loads the replacement lane - preventing the nozzle from oozing while the old spool is being ejected.

  • Changed infinite spool sequence order: tool unload → eject spool → load rollover lane (previously: change tool → eject spool)
  • Added defensive null checks using .get() for lane lookups before operations
  • Updated version to 1.0.33

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
extras/AFC_lane.py Refactored _perform_infinite_runout() to separate unload/load operations and perform spool ejection between them, with added null checks for lane validation
extras/AFC.py Incremented version number from 1.0.32 to 1.0.33
CHANGELOG.md Documented the infinite spool sequence change with clear explanation of the new order

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jimmyjon711 jimmyjon711 requested a review from ejsears November 15, 2025 14:08
@jimmyjon711 jimmyjon711 merged commit 1639446 into ArmoredTurtle:DEV Nov 16, 2025
1 check passed
@jimmyjon711 jimmyjon711 deleted the issue_549 branch November 16, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Change rollover eject sequence

2 participants