Open
Conversation
Armour
requested changes
Apr 4, 2021
Owner
Armour
left a comment
Armour
left a comment
There was a problem hiding this comment.
Hi, sorry for the late review, the code looks good! one more thing, we also want to update the lang settings in component/AvatarUpload/index.vue, components/Tinymce/index.vue and components/MarkdownEditor/index.vue, after that I think we are ready to go, thanks!
Armour
requested changes
Apr 6, 2021
| ko: 'ko', | ||
| it: 'it' | ||
| it: 'it', | ||
| br: 'br' |
| ko: 'ko_KR', | ||
| it: 'it' | ||
| it: 'it', | ||
| br: 'br' |
Owner
There was a problem hiding this comment.
please copy pt_BR file in https://www.tiny.cloud/get-tiny/language-packages/ to the public folder as mentioned above, also change this to pt_BR
| private content3 = simpleContent | ||
| private content4 = simpleContent | ||
| private html = '' | ||
| // Mapping for local lang to tuiEditor lang |
Owner
There was a problem hiding this comment.
this is moved to component/markdown instead of the demo page here, please remove this and edit it there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brazilian Portuguese option